Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standarizing output spanning tree functions #2606

Merged
merged 22 commits into from
Jan 24, 2024
Merged

Standarizing output spanning tree functions #2606

merged 22 commits into from
Jan 24, 2024

Conversation

cvvergara
Copy link
Member

Fixes #2605 .

Changes proposed in this pull request:

  • SQL add 'pred` column
  • C add pred column
  • Adjust documentation to new results
  • Adjust pgtap test
  • Add migration guide

@pgRouting/admins

@cvvergara
[sql][prim] New _primv4 function with additional output column
ec8349c
@cvvergara
[sql][prim] Adding pred column to results
723d18f
@cvvergara
[sql][kruskal] New _pgr_kruskalv4 function with additional pred outpu…
71dbd07 
…t column
@cvvergara
[sql][kruskal] Adding pred column to results
ac31387
@cvvergara
[src][kruskal] adding new _kruskalv4 C function
ab2a011
@cvvergara
[src][prim] adding new _primv4 C function
f4a0029
@cvvergara
[docqueries][prim] adjusting to new results
fc31a56
@cvvergara
[docqueries][kruskal] adjusting to new results
2918e13
@cvvergara
[tap][spanningTree] tools for types_check standarizing
efbcc4f
@cvvergara
[tap][kruskal] Error code based on version
29cc23e
@cvvergara
[tap][prim] Error code based on version
c9fcaab
@cvvergara
[doc] mst-dd-params -> spantree-params_
e45dcee
@cvvergara
[doc][kruskal] adjusting documentation to new output column
a8e7d89
@cvvergara
[doc][prim] adjusting documentation to new output column
d17b65e
@cvvergara
[doc] Adding release notes & NEWS
cf52a82
@cvvergara
[kruskal][doc] adding migration guide
2d44dc7
@cvvergara
[prim][doc] adding migration guide
4cecbe1
@cvvergara
[doc] fixing spelling mistakes
3673907
cvvergara
cvvergara commented Jan 16, 2024
View reviewed changes
src/spanningTree/kruskal.c Outdated Show resolved Hide resolved
@cvvergara
Copy link
Member Author

cvvergara commented Jan 16, 2024 •
edited
Loading

TODO

test that the predecessors are correct

@cvvergara
Copy link
Member Author

Those tests should also cover pgr_drivingDistance and pgr_withPointsDD

@cvvergara
Copy link
Member Author

cvvergara commented Jan 16, 2024 •
edited
Loading

TODO

  • Verify the upgrade scripts

@cvvergara
Copy link
Member Author

cvvergara commented Jan 16, 2024 •
edited
Loading

TODO

  • the signature file is not up to date

@cvvergara
Copy link
Member Author

predecessors check will be in another PR

@cvvergara
Copy link
Member Author

Upgrade test is passing
https://github.com/cvvergara/pgrouting/actions/runs/7574653170

@cvvergara cvvergara marked this pull request as ready for review January 19, 2024 22:41
@cvvergara cvvergara merged commit 9eb61e8 into pgRouting:develop Jan 24, 2024
22 checks passed
@cvvergara cvvergara deleted the standarizing-output-spanningTree-functions branch January 24, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robe2 robe2 Awaiting requested review from robe2

@omshinde omshinde Awaiting requested review from omshinde

@iosefa iosefa Awaiting requested review from iosefa

@krashish8 krashish8 Awaiting requested review from krashish8

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cvvergara