Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linting the code for TRSP based on the C and C++ google guidelines. #787

Merged
merged 5 commits into from
May 17, 2017
Merged

Linting the code for TRSP based on the C and C++ google guidelines. #787

merged 5 commits into from
May 17, 2017

Conversation

vidhan13j07
Copy link
Member

@vidhan13j07 vidhan13j07 commented May 16, 2017 •
edited
Loading

  • src/trsp/src/trsp.c

  • src/trsp/src/GraphDefinition.cpp

  • src/trsp/src/trsp_core.cpp

  • src/trsp/src/trsp_driver.cpp

  • src/trsp/src/trsp.h

  • src/trsp/src/utils.h

@vidhan13j07 vidhan13j07 requested a review from XJTUmg May 16, 2017 18:06
@vidhan13j07 vidhan13j07 changed the title [WIP]Linted the code for src/trsp/src/trsp.c based on the C and C++ google guidelines. [WIP]Linted the code for TRSP based on the C and C++ google guidelines. May 16, 2017
@vidhan13j07 vidhan13j07 changed the title [WIP]Linted the code for TRSP based on the C and C++ google guidelines. [WIP]Linting the code for TRSP based on the C and C++ google guidelines. May 16, 2017
@cvvergara cvvergara self-requested a review May 16, 2017 18:24
@cvvergara
Copy link
Member

cvvergara commented May 16, 2017 •
edited
Loading

My Reviewing:
OK for:

  • src/trsp/src/trsp.c
  • src/trsp/src/GraphDefinition.cpp
  • src/trsp/src/trsp_core.cpp
  • src/trsp/src/trsp_driver.cpp
  • src/trsp/src/trsp.h
  • src/trsp/src/utils.h

@cvvergara
Copy link
Member

@vidhan13j07
Please provide a description (edit the first comment), it can be the list of tasks, just as you have it in your issue
vidhan13j07#6

@cvvergara
Copy link
Member

cvvergara commented May 16, 2017 •
edited
Loading

@XJTUmg Add a comment, just like I did for keeping track of the on going review by you

@cvvergara cvvergara added this to the Release 2.5.0 milestone May 16, 2017
@vidhan13j07
Copy link
Member Author

vidhan13j07 commented May 16, 2017 •
edited
Loading

Linter Errors remaining: https://gist.github.com/vidhan13j07/223475f516068f829f874fb83ca9d27a

@vidhan13j07 vidhan13j07 changed the title [WIP]Linting the code for TRSP based on the C and C++ google guidelines. Linting the code for TRSP based on the C and C++ google guidelines. May 16, 2017
cvvergara
cvvergara approved these changes May 16, 2017
View reviewed changes
Copy link
Member

@cvvergara cvvergara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Things look ok, only formatting changes

@cvvergara
Copy link
Member

@vidhan13j07 I'll wait for merging when all the three of you finish, so that I only regenerate the developers documentation once

XJTUmg
XJTUmg approved these changes May 17, 2017
View reviewed changes
Copy link
Contributor

@XJTUmg XJTUmg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

finished reviewing all changes

@cvvergara cvvergara merged commit fa2692c into pgRouting:develop May 17, 2017
@vidhan13j07 vidhan13j07 deleted the lint/trsp branch May 18, 2017 07:14
@vidhan13j07 vidhan13j07 restored the lint/trsp branch May 18, 2017 20:32
@vidhan13j07 vidhan13j07 deleted the lint/trsp branch May 18, 2017 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XJTUmg XJTUmg XJTUmg approved these changes

@cvvergara cvvergara cvvergara approved these changes

Assignees

@vidhan13j07 vidhan13j07

Labels
Enhancement TRSP
Projects
None yet
Milestone
Release 2.5.0
Development

Successfully merging this pull request may close these issues.
4 participants
@vidhan13j07 @cvvergara @XJTUmg @dkastl