Fixed an issue where server config information was visible to non-admin users. #6769 #6922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adityatoshniwal
requested changes
Nov 2, 2023
There was a problem hiding this comment.
The info is still coming in the API. Hiding from UI is not enough.
Change the backend API to not return the config data, and in the front end simply check if the data is available then show else hide.
Update: Desktop users are always admin, so no check required for server or desktop. Admin should be enough.
pravesh-sharma
force-pushed
the
GH-6769
branch
from
52b9bad to
af005da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.