Fix issues with profile setting dialog #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
pganssle
commented
Dec 1, 2024
pganssle
commented
- More gracefully handle the situation where we get into an illegal state where the profile ID corresponds to a deleted or otherwise non-existent profile.
- Switch the profile adder / settings adjuster dialogue away from being an infobox, so now the only way to toggle it is with the X or one of the buttons.
- Make it so that you fall back to the guest profile when a profile is deleted.
- Various fixes related to visibility of the profile settings adder / adjuster in different scenarios.
1. More gracefully handle the situation where we get into an illegal state where the profile ID corresponds to a deleted or otherwise non-existent profile. 2. Switch the profile adder / settings adjuster dialogue away from being an infobox, so now the only way to toggle it is with the X or one of the buttons. 3. Make it so that you fall back to the guest profile when a profile is deleted. 4. Various fixes related to visibility of the profile settings adder / adjuster in different scenarios.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.