Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error Handling #4

Open
pgaref opened this issue Jul 13, 2016 · 1 comment
Open

Error Handling #4

pgaref opened this issue Jul 13, 2016 · 1 comment
Labels
enhancement

Comments

@pgaref
Copy link
Owner

pgaref commented Jul 13, 2016 •
edited
Loading

Since we are using HTML parsers and each proxy list web page can change radically overnight it would really make sense to have some custom exception handling trying to translate that kind of errors
@pgaref pgaref mentioned this issue Jul 13, 2016
Merged
@ieguiguren
Copy link
Contributor

I got your point. Working on it.

pgaref added a commit that referenced this issue Jul 14, 2016
@pgaref
Some work on #3 and #4 . Created parser abstraction and now each web_…
8358574 
…url is a separate class extending UrlParser. This should simplify things a lot when adding new proxy providers. Created custom Parser exception as a first step towards custom exception handling.
@gabrielgradinaru gabrielgradinaru mentioned this issue Apr 17, 2017
Merged
pgaref pushed a commit that referenced this issue Aug 8, 2017
Proper error handling #4 when providers are not completely unreachabl…
ec84df5 
…e but page format has changed. Verbose logging messages are printed for ValueErrors, KeyErrors and generic Exceptions as part of the parse_proxyList method.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ieguiguren @pgaref