always compile pgrx_embed_* without opts
#1838
Merged
+7
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
I believe that it would be possible for cargo to manage this via rust-lang/cargo#6529 but they have so far chosen not to implement that. |
|
something something filetimes drool content-addressable storage rules |
workingjubilee
changed the title
pgrx_embed_* without opts
eeeebbbbrrrr
added a commit
that referenced
this pull request
Sep 6, 2024
Welcome to pgrx v0.12.2. This is a minor release that fixes a few bugs, improves compilation times with `cargo pgrx run/install/test`, and adds a few more Postgres headers. As usual, please `cargo install cargo-pgrx --version 0.12.2 --locked`. Then you can run `cargo pgrx upgrade` in your extension crate's root to update its dependencies. ## What's Changed * [ `CPPFLAGS`] Switch to `USE_ASSERT_CHECKING` by @SamuelMarks in #1826 * Add UnboxDatum for Range<T> by @mhov in #1827 * Moved Sized from FromDatum methods to trait by @YohDeadfall in #1831 * Used SPI result type for cursor API by @YohDeadfall in #1836 * always compile `pgrx_embed_*` without opts by @eeeebbbbrrrr in #1838 * Fixed out of bounds reads for open_cursor by @YohDeadfall in #1837 * Include `access/visibilitymap.h` and `utils/tuplestore.h` by @eeeebbbbrrrr in #1841 ## New Contributors Thanks to these folks for their first-time contributions -- it's greatly appreciated! * @SamuelMarks made their first contribution in #1826 * @YohDeadfall made their first contribution in #1831 **Full Changelog**: v0.12.1...v0.12.2
usamoi
pushed a commit
to tensorchord/pgrx
that referenced
this pull request
Mar 6, 2025
This addresses issue pgcentralfoundation#1835 by always compiling the `pgrx_embed_xxx` binary in debug mode. Essentially, `cargo pgrx` now ignores the `--release` or `--profile XXX` arguments when compiling the `pgrx_embed_xxx` binary.
usamoi
pushed a commit
to tensorchord/pgrx
that referenced
this pull request
Mar 6, 2025
Welcome to pgrx v0.12.2. This is a minor release that fixes a few bugs, improves compilation times with `cargo pgrx run/install/test`, and adds a few more Postgres headers. As usual, please `cargo install cargo-pgrx --version 0.12.2 --locked`. Then you can run `cargo pgrx upgrade` in your extension crate's root to update its dependencies. ## What's Changed * [ `CPPFLAGS`] Switch to `USE_ASSERT_CHECKING` by @SamuelMarks in pgcentralfoundation#1826 * Add UnboxDatum for Range<T> by @mhov in pgcentralfoundation#1827 * Moved Sized from FromDatum methods to trait by @YohDeadfall in pgcentralfoundation#1831 * Used SPI result type for cursor API by @YohDeadfall in pgcentralfoundation#1836 * always compile `pgrx_embed_*` without opts by @eeeebbbbrrrr in pgcentralfoundation#1838 * Fixed out of bounds reads for open_cursor by @YohDeadfall in pgcentralfoundation#1837 * Include `access/visibilitymap.h` and `utils/tuplestore.h` by @eeeebbbbrrrr in pgcentralfoundation#1841 ## New Contributors Thanks to these folks for their first-time contributions -- it's greatly appreciated! * @SamuelMarks made their first contribution in pgcentralfoundation#1826 * @YohDeadfall made their first contribution in pgcentralfoundation#1831 **Full Changelog**: pgcentralfoundation/pgrx@v0.12.1...v0.12.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses issue #1835 by always compiling the
pgrx_embed_xxxbinary in debug mode.Essentially,
cargo pgrxnow ignores the--releaseor--profile XXXarguments when compiling thepgrx_embed_xxxbinary.(I am not sure how we can avoid the re-compile completely. My thought was somehow detecting that the contents of the
PGRX_EMBEDfile (which is a temp file generated on every build) haven't actually changed, but I don't know what we'd compare it to?)Anyways, this PR solves my annoyance and I think it should be sufficient for the OP too.