Added callback function to send additional data before pageview is sent #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -13,6 +16,8 @@ export default Ember.Mixin.create({ | |||
| if (trackerType === 'analytics.js') { | |||
| var globalVariable = Ember.getWithDefault(ENV, 'googleAnalytics.globalVariable', 'ga'); | |||
|
|
|||
| this.beforePageviewToGA(window[globalVariable]); | |||
Apparently I didn't have my editor set to correctly autoformat the indentation
|
lgtm 👍 |
pgrippi
pushed a commit
that referenced
this pull request
Oct 27, 2015
Added callback function to send additional data before pageview is sent
|
Version 1.5.0 released on npm with this PR included |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our application we want to track a number of custom dimensions in addition to the default statistics logged by Google. This requires us to call
ga('set', 'dimensionName', 'value');beforega('send', 'pageview');is called (source: https://support.google.com/analytics/answer/2709828). To this end, I've added a custom function to the mixin which is called prior to sending the pageview, with a default empty implementation.