Keep from_value interface consistent

pgxn · Sep 6, 2024 · 9180f9e · 9180f9e
1 parent 3930bb0
commit 9180f9e
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/src/meta/mod.rs b/src/meta/mod.rs
@@ -277,7 +277,7 @@ pub struct Meta {
 impl Meta {
     fn from_version(version: u8, meta: Value) -> Result<Self, Box<dyn Error>> {
         match version {
-            1 => v1::from_value(&meta),
+            1 => v1::from_value(meta),
             2 => v2::from_value(meta),
             _ => Err(Box::from(format!("Unknown meta version {version}"))),
         }

diff --git a/src/meta/v1/mod.rs b/src/meta/v1/mod.rs
@@ -44,8 +44,8 @@ pub fn to_v2(v1: &Value) -> Result<Value, Box<dyn Error>> {
 
 /// from_value parses v1, which contains PGXN v1 metadata, into a Meta object
 /// containing valid PGXN v2 metadata.
-pub fn from_value(v1: &Value) -> Result<Meta, Box<dyn Error>> {
-    Meta::try_from(to_v2(v1)?)
+pub fn from_value(v1: Value) -> Result<Meta, Box<dyn Error>> {
+    Meta::try_from(to_v2(&v1)?)
 }
 
 /// v1_to_v2_common sets up a new v2 map with compatible fields copied from v1

diff --git a/src/meta/v1/tests.rs b/src/meta/v1/tests.rs
@@ -662,7 +662,7 @@ fn test_from_value() -> Result<(), Box<dyn Error>> {
     for path in glob.walk(dir) {
         let path = path?.into_path();
         let meta: Value = serde_json::from_reader(File::open(&path)?)?;
-        if let Err(e) = from_value(&meta) {
+        if let Err(e) = from_value(meta) {
             panic!("{:?} failed: {e}", path.file_name().unwrap());
         }
         println!("Example {:?} ok", path.file_name().unwrap());