Test and fix serialization #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 5 5
Lines 525 529 +4
=========================================
+ Hits 525 529 +4 ☔ View full report in Codecov by Sentry. |
Add `TryFrom<Meta> for Value` and `TryFrom<&Meta> for String` to handle serialization. Then add tests to ensure that Meta object loaded from v2 meta files deserialize into the same data structure. Done mainly by omitting Optional fields set to `None`, but also by eliminating the `meta-spec.url` default value and a custom `x_` property, which will be restored in a future commit. In the process, add support for badges in the resources object. This was an oversight in e803409. While at it, change a parameter instance of `&Vec<T>` to `&[T]`.
vrmiguel
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
TryFrom<Meta> for ValueandTryFrom<&Meta> for Stringto handle serialization.Then add tests to ensure that Meta object loaded from v2 meta files deserialize into the same data structure. Done mainly by omitting Optional fields set to
None, but also by eliminating themeta-spec.urldefault value and a customx_property, which will be restored in a future commit.In the process, add support for badges in the resources object. This was an oversight in e803409.
While at it, change a parameter instance of
&Vec<T>to&[T].