Add release module #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-validation #28 +/- ##
=====================================================
Coverage 100.00% 100.00%
=====================================================
Files 6 8 +2
Lines 887 1040 +153
=====================================================
+ Hits 887 1040 +153 ☔ View full report in Codecov by Sentry. |
vrmiguel
reviewed
Sep 23, 2024
vrmiguel
approved these changes
Sep 23, 2024
The new `Release` struct encapsulates `Distribution` and adds a `release` field that contains JWS-signed release metadata. It currently only supports v2 metadata, but offers the same traits, constructors, and accessors as `Distribution`, plus the `release()` accessor and associated objects. Add tests for all of these bits, using both the v2 corpus with a release patch applied and custom JSON objects to test each individual struct and its accessors. Writing the tests for the `TryFrom<PathBuf>` when what was on hand was a `Path` led to a bit of research and the conclusion that one does not convert a file path into a struct, but loads it into a struct. So create the `load` function, instead, and have it accept a `AsRef<Path>` argument, which covers `Path`s, `PathBuf`s, and strings. Back-patch this change to `Distribution`, as well, and take advantage of `.try_into()` where possible.
theory
force-pushed
the
release-struct
branch
from
2923488 to
88b2183
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new
Releasestruct encapsulatesDistributionand adds areleasefield that contains JWS-signed release metadata. It currently only supports v2 metadata, but offers the same traits, constructors, and accessors asDistribution, plus therelease()accessor and associated objects.Add tests for all of these bits, using both the v2 corpus with a release patch applied and custom JSON objects to test each individual struct and its accessors.
Writing the tests for the
TryFrom<PathBuf>when what was on hand was aPathled to a bit of research and the conclusion that one does not convert a file path into a struct, but loads it into a struct. So create theloadfunction, instead, and have it accept aAsRef<Path>argument, which coversPaths,PathBufs, and strings. Back-patch this change toDistribution, as well, and take advantage of.try_into()where possible.