Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace dist errors #37

Merged
merged 1 commit into from
Nov 14, 2024
Merged

Replace dist errors #37

merged 1 commit into from
Nov 14, 2024

Conversation

theory
Copy link
Member

@theory theory commented Nov 13, 2024

Add property validation and parameter errors to the error module and replace all Box<Error>s in the dist module with error:Errors.

Also, make the first word of all error messages consistently lowercase.

@theory theory added the enhancement New feature or request label Nov 13, 2024
@theory theory requested a review from vrmiguel November 13, 2024 19:32
@theory theory self-assigned this Nov 13, 2024
Add property validation and parameter errors to the error module and
replace all `Box<Error>`s in the dist module with `error:Error`s.

Also, make the first word of all error messages consistently lowercase.
Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (3100dbd) to head (fb02ea2).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #37   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines         1103      1094    -9     
=========================================
- Hits          1103      1094    -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@vrmiguel vrmiguel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! 🚀🚀🚀

Base automatically changed from thiserror to main November 14, 2024 22:16
@theory theory merged commit fb02ea2 into main Nov 14, 2024
138 checks passed
@theory theory deleted the more-thiserror branch November 14, 2024 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants