Replace remaining errors #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #38 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 1094 1088 -6
=========================================
- Hits 1094 1088 -6 ☔ View full report in Codecov by Sentry. |
All the APIs now return errors from the error module in this crate. The
only bits left that return boxed errors are:
* The custom JSON Schema format validation functions in
`src/valid/compiler/mod.rs`, which are required to be boxed errors
by the boon crate.
* `build.rs` and `main.rs`, where it seems harmless, since those
errors are always printed ton the terminal.
theory
force-pushed
the
release-thiserror
branch
from
c84277d to
bf6db96
Compare
vrmiguel
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the APIs now return errors from the error module in this crate. The only bits left that return boxed errors are:
src/valid/compiler/mod.rs, which are required to be boxed errors by the boon crate.build.rsandmain.rs, where it seems harmless, since those errors are always printed ton the terminal.