Metadata uploader - PARSE FILE

[ksierks]

Description of changes

What did you change in this pull request? Provide a description of files changed, user interactions changed, etc. Include how to test your changes.

Related issue

Link to the GitHub issue this pull request addresses using the #issuenum format. If it completes an issue, use Fixes #issuenum to automatically close the issue.

Checklist

Things for the developer to confirm they've done before the PR should be accepted:

• CHANGELOG.md (and UPGRADING.md if necessary) updated with information for new change.
• Tests added (or description of how to test) for any new features.
• User documentation updated for UI or technical changes.

[joshsadam]

A couple of comments:

1. When you click the next step button, ensure you show some sort of indicator (maybe a spinner on the button) to give the user some affordance that something is going on.
2. Can you try using virtualized tables row, I tried to load a huge file into the uploader (4000 samples w/ 40 columns). The table does not react to any scroll events. Too many DOM elements were created.

[joshsadam]

Please make all these files TypeScript.

[joshsadam]

Instead of modifying the metadata object imported from the spreadsheet, I think it would work better if you store the validation object, with a sample name key to look it up. This will prevent you from having to modify the entire metadata object (leaving 2 large objects in memory temporarily).

Instead up uploading one at a time, it might be a lot faster to do chunk uploads.

[joshsadam]

I starting reviewing your code this morning, but I need you to do me a favour first. This first file that I have been reviewing, all my comments are errors that are picked up by eslint. Can you go through your PR and make sure that you fix the eslint and any other error the editor is warning you about (if possible). I have also started using a plugin called sonar lint that has been really helpful in finding other code smells that I would have missed. Thanks.

[joshsadam]

I found a situation where if a user refreshes the page while doing an upload their state is lost but they remain on the step they were at:

What might work well is keeping the state of the metadata in sessionStorage, then onload check the step and see if there is anything is storage. You should probably confirm the project id and maybe timestamp it.

[joshsadam]

Sorry there is a big request in here that I wanted to get to you. I will still go through the other files.

[joshsadam]

A couple more things

[joshsadam]

Just one tiny thing

[ericenns]

👍 Approved thanks for completing the file parsing, I have tested it and it worked as I expected.