Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sample details refactor/ documentation #1366

Conversation

deepsidhu85
Copy link
Contributor

Description of changes

What did you change in this pull request? Provide a description of files changed, user interactions changed, etc. Include how to test your changes.

Related issue

Link to the GitHub issue this pull request addresses using the #issuenum format. If it completes an issue, use Fixes #issuenum to automatically close the issue.

Checklist

Things for the developer to confirm they've done before the PR should be accepted:

* [ ] CHANGELOG.md (and UPGRADING.md if necessary) updated with information for new change.
* [ ] Tests added (or description of how to test) for any new features.

  • User documentation updated for UI or technical changes.

@deepsidhu85 deepsidhu85 marked this pull request as ready for review September 15, 2022 21:14
@deepsidhu85 deepsidhu85 added the documentation Issues relating to IRIDA's documentation label Sep 29, 2022
@joshsadam
Copy link
Contributor

So I have a small problem with your screen shots. It is hard to tell they are modals by the way you have them cropped. @ericenns and I have been working on a ton of screen shots recently, and for all of them, including modals, we like to capture the whole screen at 1600px. This prevent modal or smaller screen areas from totally blowing up when viewed.

@deepsidhu85
Copy link
Contributor Author

So I have a small problem with your screen shots. It is hard to tell they are modals by the way you have them cropped. @ericenns and I have been working on a ton of screen shots recently, and for all of them, including modals, we like to capture the whole screen at 1600px. This prevent modal or smaller screen areas from totally blowing up when viewed.

As discussed the docs are getting a complete overhaul so we are going to leave as is for now

@joshsadam joshsadam merged commit 62298e1 into phac-nml:sample-details-refactor Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Issues relating to IRIDA's documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants