Sample details refactor/ cleanup #1374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ails_refactor/_cleanup
deepsidhu85
changed the base branch from
development
to
sample-details-refactor
deepsidhu85
added
back-end
|
I think you still need to remove |
joshsadam
requested changes
Oct 3, 2022
There was a problem hiding this comment.
I think those last 2 files and this should be GTG. Thanks @deepsidhu85 and @ericenns
joshsadam
approved these changes
Oct 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
What did you change in this pull request? Provide a description of files changed, user interactions changed, etc. Include how to test your changes.
Removed files and translations that are no longer required.
Related issue
Link to the GitHub issue this pull request addresses using the
#issuenumformat. If it completes an issue, useFixes #issuenumto automatically close the issue.Checklist
Things for the developer to confirm they've done before the PR should be accepted:
* [ ] CHANGELOG.md (and UPGRADING.md if necessary) updated with information for new change.* [ ] Tests added (or description of how to test) for any new features.* [ ] User documentation updated for UI or technical changes.