Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix remove samples from project #1396

Merged
merged 8 commits into from
Nov 2, 2022

Conversation

joshsadam
Copy link
Contributor

Description of changes

Fixes issue preventing sharing of locked samples from the UI.

Related issue

N/A

Checklist

Things for the developer to confirm they've done before the PR should be accepted:

  • CHANGELOG.md (and UPGRADING.md if necessary) updated with information for new change.
  • Tests added (or description of how to test) for any new features.
  • User documentation updated for UI or technical changes.

@ericenns ericenns force-pushed the hotfix-remove-samples-from-project branch from e34433f to 60fd01a Compare November 1, 2022 17:48
Copy link
Member

@ericenns ericenns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 This now works as intended, Thanks @joshsadam

@ericenns ericenns merged commit c0d6dfa into master Nov 2, 2022
@ericenns ericenns deleted the hotfix-remove-samples-from-project branch November 2, 2022 19:54
Copy link
Member

@ericenns ericenns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wish I could delete this, wrong PR lol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants