Hotfix: Sample details modal add/remove to/from cart #1397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iewer, then closed, reopened, it would still have an add to cart button until the page was refreshed. Updated previous refetch to refetchCart
…e sample detail viewer if the sample was previously added to the cart, the viewer closed, then relaunched
…sample is added or removed to/from the cart then the SampleDetails tag is invalidated and a fresh query is made to the server to get updated sample info
…ing the modal to close
ericenns
approved these changes
Nov 3, 2022
There was a problem hiding this comment.
👍 I test this locally and it now works as expected. Thanks @deepsidhu85
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
What did you change in this pull request? Provide a description of files changed, user interactions changed, etc. Include how to test your changes.
Fixed bug with sample details viewer which would still display a
Add to Cartbutton to if the modal was closed and relaunched after the sample was added to the cart from the viewer.Steps to reproduce before fix:
Add to Cartbutton. Should now display theRemove from CartbuttonAdd to CartbuttonTo test fix:
Add to Cartbutton. Should now display theRemove from CartbuttonRemove from CartbuttonRelated issue
Link to the GitHub issue this pull request addresses using the
#issuenumformat. If it completes an issue, useFixes #issuenumto automatically close the issue.Checklist
Things for the developer to confirm they've done before the PR should be accepted:
* [ ] User documentation updated for UI or technical changes.