Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEPENDENCY: Updated react-router to 6.4.3 #1405

Merged
merged 3 commits into from
Nov 15, 2022

Conversation

joshsadam
Copy link
Contributor

@joshsadam joshsadam commented Nov 4, 2022

Description of changes

Updates react-router to the stable version. Had to clean up how ProjectSPA was set up, which will be good for our upcoming project to make all project pages an SPA.

Related issue

N/A

Checklist

Things for the developer to confirm they've done before the PR should be accepted:

  • CHANGELOG.md (and UPGRADING.md if necessary) updated with information for new change.
  • Tests added (or description of how to test) for any new features.
  • User documentation updated for UI or technical changes.

@joshsadam joshsadam requested a review from deepsidhu85 November 7, 2022 13:25
@joshsadam joshsadam added UI User Interface Issue dependencies Pull requests that update a dependency file labels Nov 7, 2022
@joshsadam joshsadam requested review from ericenns and removed request for deepsidhu85 November 8, 2022 16:22
@joshsadam joshsadam assigned ericenns and unassigned deepsidhu85 Nov 8, 2022
Copy link
Member

@ericenns ericenns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ericenns ericenns merged commit 75d544b into development Nov 15, 2022
@ericenns ericenns deleted the dependency-react-router branch November 15, 2022 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file UI User Interface Issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants