Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --strip-trailing-whitespace #129

Merged
merged 2 commits into from
May 17, 2023
Merged

Add --strip-trailing-whitespace #129

merged 2 commits into from
May 17, 2023

Conversation

phadej
Copy link
Owner

@phadej phadej commented May 16, 2023

@RyanGlScott I tested this locally with trifecta. I'll appreciate if you check this too before I make a release and wire new version into haskell-ci.

@RyanGlScott
Copy link
Contributor

Thanks, @phadej! I've also verified that this works locally.

One naming question: should we name the flag to be the same thing that diff uses? diff has a family of flags related to whitespace:

$ diff --help
<...>
  -E, --ignore-tab-expansion      ignore changes due to tab expansion
  -Z, --ignore-trailing-space     ignore white space at line end
  -b, --ignore-space-change       ignore changes in the amount of white space
  -w, --ignore-all-space          ignore all white space
  -B, --ignore-blank-lines        ignore changes where lines are all blank

What this PR calls --strip-trailing-whitespace corresponds to diff's --ignore-trailing-space. Do you think it's worth naming it --ignore-trailing-space on the cabal-docspec side for consistency's sake?

@phadej phadej force-pushed the trailing-whitespace branch from 52a193e to 8dd612c Compare May 17, 2023 05:50
@phadej
Copy link
Owner Author

phadej commented May 17, 2023

@RyanGlScott good point. I changed the flag name

@phadej phadej force-pushed the trailing-whitespace branch from 8dd612c to 22e5f84 Compare May 17, 2023 08:05
@phadej phadej merged commit 7040a52 into master May 17, 2023
@phadej phadej deleted the trailing-whitespace branch May 17, 2023 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants