Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 use named tuple instead of return order #36

Merged
merged 2 commits into from
May 24, 2023
Merged

Conversation

Anon-136
Copy link
Member

@Anon-136 Anon-136 commented May 23, 2023

There is a problem in the code below that it doesn't always return a row in the same order

Screenshot 2566-05-24 at 03 06 22

For example, queue[21] can be a testcase in a system but a timestamp in another system

What I found is that we can use named dict/tuple from db query

https://stackoverflow.com/a/21158159

but i needed to upgrade to psycopg2 and did some weird installation to make it work with alpine

Ref: psycopg/psycopg2#684

Please review!

@Anon-136 Anon-136 requested a review from Nepumi-Jr May 23, 2023 20:11
Copy link
Member

@Nepumi-Jr Nepumi-Jr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Anon-136 Anon-136 merged commit aac2d61 into main May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants