Fixed segfault in PHP5.6 dispatching, prevented double dispatch #12209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exceptions, and improved documentation/test-suite for dispatcher components [phalcon#12154](phalcon#12154), [phalcon#11819](phalcon#11819)
|
As you see tests fails. |
phalcon/dispatcher.zep
Outdated
| * @return object | ||
| * @return object|false Returns the dispatched handler class (the Controller for Mvc dispatching or or a Task | ||
| * for Cli dispatching) or <tt>false</tt> if an exception occurred and the operation was | ||
| * stopped by returning <tt>false</tt> in the exception handler. |
There was a problem hiding this comment.
You have to use spaces in dockblocks
strict array parameter type (To be updated in 4.0.x)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the long-standing Mvc Dispatcher bugs in PHP5.6. #12154, #11819