Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change column modification behaviour during table morph #97

Closed
Jeckerson opened this issue Jul 1, 2020 · 0 comments · Fixed by #123
Closed

Change column modification behaviour during table morph #97

Jeckerson opened this issue Jul 1, 2020 · 0 comments · Fixed by #123
Assignees
@BeMySlaveDarlin
Labels
bug Something isn't working
Milestone
2.2.x

Comments

@Jeckerson
Copy link
Member

During table morphing, if table column was just renamed, it will drop it and add new one, which will cause data loss.

Suggestion: check if column data is the same, but just name is different and just rename it.
@Jeckerson Jeckerson self-assigned this Jul 1, 2020
@Jeckerson Jeckerson added this to the 2.1.x milestone Aug 29, 2020
@Jeckerson Jeckerson added the enhancement New feature or request label Aug 31, 2020
@Jeckerson Jeckerson modified the milestones: 2.1.x, 2.2.x Feb 28, 2021
@Jeckerson Jeckerson added bug Something isn't working and removed enhancement New feature or request labels Mar 21, 2021
@BeMySlaveDarlin BeMySlaveDarlin mentioned this issue Aug 9, 2021
Merged
3 tasks
BeMySlaveDarlin added a commit to BeMySlaveDarlin/migrations that referenced this issue Aug 9, 2021
@BeMySlaveDarlin
phalcon#97 - Renaming column does not drops column on morphTable
0472fed
BeMySlaveDarlin added a commit to BeMySlaveDarlin/migrations that referenced this issue Aug 9, 2021
@BeMySlaveDarlin
phalcon#97 - Renaming column does not drops column on morphTable
1b6b57d
@Jeckerson Jeckerson linked a pull request Aug 11, 2021 that will close this issue
ISSUE-97: Renaming column does not drops column on morphTable #123
Merged
3 tasks
@niden niden moved this to Released in Phalcon v5 Aug 25, 2022
@niden niden added this to Phalcon v5 Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BeMySlaveDarlin BeMySlaveDarlin

Labels
bug Something isn't working
Projects
Phalcon v5
Archived in project
Milestone
2.2.x
Development

Successfully merging a pull request may close this issue.

ISSUE-97: Renaming column does not drops column on morphTable BeMySlaveDarlin/migrations
2 participants
@Jeckerson @BeMySlaveDarlin