Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE-90: Added new code generator #121

Merged
merged 1 commit into from
Aug 8, 2021

Conversation

BeMySlaveDarlin
Copy link
Contributor

@BeMySlaveDarlin BeMySlaveDarlin commented Aug 8, 2021

Hello!

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR

Small description of change:
Migrations code generator changed from Phalcon\Migrations\Generator\Snippet to nette/php-generator

Thanks

@codecov
Copy link

codecov bot commented Aug 8, 2021

Codecov Report

Merging #121 (65ae6fb) into 2.2.x (9771725) will increase coverage by 2.75%.
The diff coverage is 84.15%.

@@             Coverage Diff              @@
##              2.2.x     #121      +/-   ##
============================================
+ Coverage     53.38%   56.14%   +2.75%     
- Complexity      525      529       +4     
============================================
  Files            20       21       +1     
  Lines          1433     1482      +49     
============================================
+ Hits            765      832      +67     
+ Misses          668      650      -18     

@Jeckerson Jeckerson merged commit 8518ffb into phalcon:2.2.x Aug 8, 2021
@BeMySlaveDarlin BeMySlaveDarlin deleted the new-code-generation branch August 9, 2021 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants