Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#126 - Fix update column name alg #127

Merged

Conversation

BeMySlaveDarlin
Copy link
Contributor

Hello!

  • Type: bug fix | new feature | code quality | documentation
  • Link to issue:

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR

Small description of change:
Fixed definition change checks on column update name logic

Thanks

@BeMySlaveDarlin BeMySlaveDarlin self-assigned this Nov 30, 2021
@BeMySlaveDarlin BeMySlaveDarlin linked an issue Nov 30, 2021 that may be closed by this pull request
@BeMySlaveDarlin BeMySlaveDarlin added the bug Something isn't working label Nov 30, 2021
@BeMySlaveDarlin BeMySlaveDarlin force-pushed the issue/126-fix-update-column-name branch 3 times, most recently from a2a1afe to 2bb5c1e Compare November 30, 2021 22:06
@BeMySlaveDarlin BeMySlaveDarlin force-pushed the issue/126-fix-update-column-name branch from 2bb5c1e to 34e6d6e Compare November 30, 2021 22:19
@codecov
Copy link

codecov bot commented Nov 30, 2021

Codecov Report

Merging #127 (34e6d6e) into master (4a57782) will decrease coverage by 0.07%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master     #127      +/-   ##
============================================
- Coverage     57.72%   57.65%   -0.08%     
+ Complexity      550      548       -2     
============================================
  Files            22       22              
  Lines          1533     1535       +2     
============================================
  Hits            885      885              
- Misses          648      650       +2     

@Jeckerson Jeckerson merged commit afbd64c into phalcon:master Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Columns are scrambled when using TEXT data type
2 participants