Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade lucas/phpdotenv dependency to v4 #1460

Closed
ghost opened this issue May 22, 2020 · 3 comments
Closed

Upgrade lucas/phpdotenv dependency to v4 #1460

ghost opened this issue May 22, 2020 · 3 comments
Assignees
@Jeckerson
Labels
Hacktoberfest

Comments

@ghost
Copy link

ghost commented May 22, 2020 •
edited by ghost
Loading

Expected and Actual Behavior

Describe what you are trying to achieve and what goes wrong.

I am currently using lucas/phpdotenv in my project and it is at version 4. However if I want to install phalcon-devtools, it requires me downgrade the phpdotenv in my project to 3.6.

Provide output if related

image

I would be able to make a pull request if you also feel like this can be addressed.
@quinnjr
Copy link

quinnjr commented May 27, 2020 •
edited
Loading

Taking a cursory look over the library, I can't find any actual invocation of Dotenv. The only uses of environment variables are through getenv().

Perhaps the requirement should be dropped altogether since Dotenv v5 is also available?

Edit: In general, it looks like the versions of multiple requirements need to be updated.

@Jeckerson Jeckerson self-assigned this May 27, 2020
pgalocha added a commit to pgalocha/phalcon-devtools that referenced this issue Oct 9, 2020
@pgalocha
phalcon#1460 - Removing vlucas/phpdotenv package from composer.json
ace7ae3
pgalocha added a commit to pgalocha/phalcon-devtools that referenced this issue Oct 9, 2020
@pgalocha
phalcon#1460 - Add vlucas/phpdotenv package from composer.json
66c41ce
pgalocha added a commit to pgalocha/phalcon-devtools that referenced this issue Oct 9, 2020
@pgalocha
phalcon#1460 - Remove vlucas/phpdotenv package from composer.json
8c1122d
pgalocha added a commit to pgalocha/phalcon-devtools that referenced this issue Oct 9, 2020
@pgalocha
phalcon#1460 - Require latest version of package vlucas/phpdotenv
324bd8d
pgalocha added a commit to pgalocha/phalcon-devtools that referenced this issue Oct 9, 2020
@pgalocha
phalcon#1460 - Fix codeception version that collapses with vlucas/php…
b901799 
…dotenv package
pgalocha added a commit to pgalocha/phalcon-devtools that referenced this issue Oct 9, 2020
@pgalocha
phalcon#1460 - Fix codeception version that collapses with vlucas/php…
60ab7b2 
…dotenv package
pgalocha added a commit to pgalocha/phalcon-devtools that referenced this issue Oct 9, 2020
@pgalocha
phalcon#1460 - Insert dependency packages
06dba59
pgalocha added a commit to pgalocha/phalcon-devtools that referenced this issue Oct 9, 2020
@pgalocha
phalcon#1460 - Alter codeception package to stable version
6a78173
Jeckerson added a commit that referenced this issue Oct 9, 2020
@Jeckerson
Merge pull request #1473 from pgalocha/4.0.x-remove-composer
575f456 
#1460 - Remove vlucas/phpdotenv package from composer.json
@misantron
Copy link
Contributor

Any updates here? Will be great to update lucas/phpdotenv to actual version.

@misantron misantron mentioned this issue Mar 5, 2021
Merged
3 tasks
@Jeckerson
Copy link
Member

Will be released in next version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Jeckerson Jeckerson

Labels
Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@quinnjr @Jeckerson @misantron