Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v4 shows phalcon version instead of devtools version #1508

Closed
Ultimater opened this issue Jul 6, 2021 · 1 comment
Closed

v4 shows phalcon version instead of devtools version #1508

Ultimater opened this issue Jul 6, 2021 · 1 comment
Assignees

Comments

@Ultimater
Copy link
Member

I tried this with PHP 7.4.21, and Phalcon 4.1.0 in combination with:
Devtools: v4.0.7, v4.1.0, and various others.
Ubuntu 20

The cause appears to be phalcon-devtools/src/Version.php using the method _getVersion() instead of getVersion() which then inherits from Phalcon itself, and thus the devtools code confuses the two versions with each other.

Merely typing: phalcon or phalcon i will incorrectly show the phalcon version instead of the devtools version.

@Ultimater Ultimater self-assigned this Jul 6, 2021
Ultimater added a commit to Ultimater/phalcon-devtools that referenced this issue Jul 7, 2021
Ultimater added a commit that referenced this issue Jul 7, 2021
…wing-phalcon-version-instead-4.0.x

Fix #1508 devtools version showing phalcon version instead for 4.0.x
Ultimater added a commit to Ultimater/phalcon-devtools that referenced this issue Jul 7, 2021
Ultimater added a commit that referenced this issue Jul 7, 2021
…wing-phalcon-version-instead-4.1.x

Fix #1508 devtools version showing phalcon version instead for 4.1.x
@Ultimater
Copy link
Member Author

This is fixed in v4.0.8 and v4.1.1

BeMySlaveDarlin pushed a commit to BeMySlaveDarlin/phalcon-devtools that referenced this issue Sep 16, 2021
niden pushed a commit that referenced this issue Sep 18, 2021
* Fix #1479 more verbose pdo driver missing errors

* Fix #1508 devtools version showing phalcon version instead for 4.1.x

* Bump version to 4.1.1

* Fix #1515 Devtools version errors with Phalcon 5

* Adjusting dependencies for PHP 8 support

* #1455 - New code generation

* #1455 - New tests and fix old tests

* #1455 - CHANGELOG

* #1455 - Removed TODOs

* #1455 - Changed static calls

* #1455 - Added escaping namespace placeholder

Co-authored-by: Kevin Yarmak <[email protected]>
Co-authored-by: Aziz Muzafarov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant