Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1305 - Fix URL during phalcon serve #1350

Merged
merged 5 commits into from
Nov 3, 2019
Merged

#1305 - Fix URL during phalcon serve #1350

merged 5 commits into from
Nov 3, 2019

Conversation

Jeckerson
Copy link
Member

@Jeckerson Jeckerson commented Nov 3, 2019 •
edited
Loading

Hello!

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR

Small description of change:

Thanks

@Jeckerson Jeckerson added this to the 3.4.x milestone Nov 3, 2019
@Jeckerson Jeckerson self-assigned this Nov 3, 2019
@Jeckerson Jeckerson marked this pull request as ready for review November 3, 2019 16:26
@ruudboon
Copy link
Member

ruudboon commented Nov 3, 2019

Looks good. thnx

@Jeckerson Jeckerson merged commit fbc578a into 3.4.x Nov 3, 2019
@Jeckerson Jeckerson deleted the fix/#1305-url-phalcon-serve branch November 3, 2019 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruudboon ruudboon ruudboon approved these changes

@sergeyklay sergeyklay sergeyklay approved these changes

@CameronHall CameronHall Awaiting requested review from CameronHall

@niden niden Awaiting requested review from niden

Assignees

@Jeckerson Jeckerson

Labels
Bug - High
Projects
None yet
Milestone
3.4.x
Development

Successfully merging this pull request may close these issues.
3 participants
@Jeckerson @ruudboon @sergeyklay