Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepend deprecated test file names #604

Merged
merged 2 commits into from
Feb 29, 2020
Merged

Conversation

rsetaluri
Copy link
Collaborator

Master is currently broken because colliding test file names introduced in a15ef78. Fixes that

@rsetaluri rsetaluri force-pushed the fix-pytest-import-errors branch from 7248010 to 48a7795 Compare February 28, 2020 23:46
@hofstee
Copy link
Collaborator

hofstee commented Feb 28, 2020

Ok so it looks like in theory you could so the thing I did and just put __init__.py inside test_deprecated/test_io_syntax/ which also gave this same python fatal error.

That said, I have no clue what's going on to get a fatal python error.

@rsetaluri rsetaluri mentioned this pull request Feb 28, 2020
@rsetaluri rsetaluri force-pushed the fix-pytest-import-errors branch 2 times, most recently from cadd974 to f86f9fb Compare February 29, 2020 00:19
Ensures build is checked into the tree.
@rsetaluri rsetaluri force-pushed the fix-pytest-import-errors branch from 072566a to 5e305ff Compare February 29, 2020 00:25
@rsetaluri rsetaluri merged commit 06796ae into master Feb 29, 2020
@rsetaluri rsetaluri deleted the fix-pytest-import-errors branch February 29, 2020 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants