Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Go explicit in PharRegistry #377

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Go explicit in PharRegistry #377

wants to merge 3 commits into from

Conversation

szepeviktor
Copy link
Contributor

From e863dce

@szepeviktor szepeviktor marked this pull request as draft August 2, 2022 08:06
@szepeviktor szepeviktor marked this pull request as ready for review August 2, 2022 08:13
@szepeviktor
Copy link
Contributor Author

💡 There is no CS rule to spot unused imports: use DOMNode;

@theseer
Copy link
Member

theseer commented Aug 2, 2022

bulb There is no CS rule to spot unused imports: use DOMNode;

We probably should add that ;)

@szepeviktor
Copy link
Contributor Author

phive/.php-cs-fixer.dist.php

Line 171 in 749915d

'no_unused_imports' => true,
?

@szepeviktor
Copy link
Contributor Author

I see! That workflow does not run on PR-s.

phive/.github/workflows/ci.yml

Line 3 in 749915d

on: [push]

@theseer
Copy link
Member

theseer commented Aug 2, 2022

I see! That workflow does not run on PR-s.

phive/.github/workflows/ci.yml

Line 3 in 749915d

on: [push]

Feel free to add that in a PR :) I'm rather busy today, sorry..

@szepeviktor szepeviktor mentioned this pull request Aug 2, 2022
Closed
@szepeviktor
Copy link
Contributor Author

@theseer Friendly ping 🏓

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@szepeviktor @theseer