make dev suffix rank works for uppercase too #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi, I wanted to release a new version after BETA, with name RC, but they were the same. I digged deeper and discoverd the score is incorrectly interpreted for uppercase. - rc -> 3 - RC -> 0 - beta -> 2 - BETA -> 0
szepeviktor
approved these changes
Dec 5, 2020
|
CI fail is unrelated
|
TomasVotruba
changed the title
|
Nice catch. Thanks. |
|
Thank you 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I wanted to release a new version after BETA, with name RC, but they were the same.
I digged deeper and discoverd the score is incorrectly interpreted for uppercase.
This PR fixes this behavior: