Closes #2644: Use all variables for extract_duplicate_records by default

[ynsec37]

Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.

Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the main branch until you have checked off each task.

• Place Closes #<insert_issue_number> into the beginning of your Pull Request Title (Use Edit button in top-right if you need to update)
• Code is formatted according to the tidyverse style guide. Run styler::style_file() to style R and Rmd files
• Updated relevant unit tests or have written new unit tests, which should consider realistic data scenarios and edge cases, e.g. empty datasets, errors, boundary cases etc. - See Unit Test Guide
• If you removed/replaced any function and/or function parameters, did you fully follow the deprecation guidance?
• Review the Cheat Sheet. Make any required updates to it by editing the file inst/cheatsheet/admiral_cheatsheet.pptx and re-upload a PDF and a PNG version of it to the same folder. (The PNG version can be created by taking a screenshot of the PDF version.)
• Update to all relevant roxygen headers and examples, including keywords and families. Refer to the categorization of functions to tag appropriate keyword/family.
• Run devtools::document() so all .Rd files in the man folder and the NAMESPACE file in the project root are updated appropriately
• Address any updates needed for vignettes and/or templates
• Update NEWS.md under the header # admiral (development version) if the changes pertain to a user-facing function (i.e. it has an @export tag) or documentation aimed at users (rather than developers). A Developer Notes section is available in NEWS.md for tracking developer-facing issues.
• Build admiral site pkgdown::build_site() and check that all affected examples are displayed correctly and that all new functions occur on the "Reference" page.
• Address or fix all lintr warnings and errors - lintr::lint_package()
• Run R CMD check locally and address all errors and warnings - devtools::check()
• Link the issue in the Development Section on the right hand side.
• Address all merge conflicts and resolve appropriately
• Pat yourself on the back for a job well done! Much love to your accomplishment!

[manciniedoardo]

Thanks @ynsec37 - this looks great! I've tested the code and it looks good to me. Thanks for also adding a new test. I've just left a couple of comments to make wording clearer.

Please feel free to also add your name in the Acknowledgments section of the README 😄

[bms63]

@bundfussr and @manciniedoardo so we are okay with combing 100 variables for duplicates? no issues we should alert users or tests should be implemented for large data?

[bundfussr]

@bundfussr and @manciniedoardo so we are okay with combing 100 variables for duplicates? no issues we should alert users or tests should be implemented for large data?

Maybe we should add a note in the documentation of the by_vars argument that omitting it could increase the run-time.

[manciniedoardo]

@bundfussr and @manciniedoardo so we are okay with combing 100 variables for duplicates? no issues we should alert users or tests should be implemented for large data?

Maybe we should add a note in the documentation of the by_vars argument that omitting it could increase the run-time.

Yes, that's a good suggestion @bundfussr

[bms63]

@ynsec37 do you mind making the small update requested please? then we can merge this in

[ynsec37]

@bms63 do you mean I need add the following note?

Maybe we should add a note in the documentation of the by_vars argument that omitting it could increase the run-time.

For example, Omitting by_vars will use increase runtime, explicitly specify the required grouping variables whenever possible.

[bms63]

@bms63 do you mean I need add the following note?

Maybe we should add a note in the documentation of the by_vars argument that omitting it could increase the run-time.

For example, Omitting by_vars will use increase runtime, explicitly specify the required grouping variables whenever possible.

Yes!! Something just alerting users to this being a potential use - like a 10 mil LB dataset will take a while to run!! :)

[ynsec37]

@bms63 , please review the following note, thank you.

[manciniedoardo]

Just some rewording suggestions from my side.

[manciniedoardo]

LGTM! Thanks @ynsec37 😄

[manciniedoardo]

Please feel free to also add your name in the Acknowledgments section of the README 😄

@ynsec37 just double checking here that you don't wish to add your name?

[bms63]

@ynsec37

I added here: #2394

[bms63]

Please feel free to also add your name in the Acknowledgments section of the README 😄

@ynsec37 just double checking here that you don't wish to add your name?

I added here - #2394

[ynsec37]

@bms63 thank you very much