Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addresses reverse dep check for get_joined_sub_data(...) using left_join(..., relationship = "many-to-many" ) #2655

Merged
merged 2 commits into from
Feb 6, 2025

Conversation

krlmlr
Copy link
Contributor

@krlmlr krlmlr commented Feb 1, 2025

This fixes warnings with a version of dplyr that seems to warn more aggressively. I wonder why plain dplyr doesn't trigger a warning here.

Wild guess: could this function be made more efficient with dplyr's new rolling joins?

  • Place Closes #<insert_issue_number> into the beginning of your Pull Request Title (Use Edit button in top-right if you need to update)
  • Code is formatted according to the tidyverse style guide. Run styler::style_file() to style R and Rmd files
  • Updated relevant unit tests or have written new unit tests, which should consider realistic data scenarios and edge cases, e.g. empty datasets, errors, boundary cases etc. - See Unit Test Guide
  • If you removed/replaced any function and/or function parameters, did you fully follow the deprecation guidance?
  • Review the Cheat Sheet. Make any required updates to it by editing the file inst/cheatsheet/admiral_cheatsheet.pptx and re-upload a PDF and a PNG version of it to the same folder. (The PNG version can be created by taking a screenshot of the PDF version.)
  • Update to all relevant roxygen headers and examples, including keywords and families. Refer to the categorization of functions to tag appropriate keyword/family.
  • Run devtools::document() so all .Rd files in the man folder and the NAMESPACE file in the project root are updated appropriately
  • Address any updates needed for vignettes and/or templates
  • Update NEWS.md under the header # admiral (development version) if the changes pertain to a user-facing function (i.e. it has an @export tag) or documentation aimed at users (rather than developers). A Developer Notes section is available in NEWS.md for tracking developer-facing issues.
  • Build admiral site pkgdown::build_site() and check that all affected examples are displayed correctly and that all new functions occur on the "Reference" page.
  • Address or fix all lintr warnings and errors - lintr::lint_package()
  • Run R CMD check locally and address all errors and warnings - devtools::check()
  • Link the issue in the Development Section on the right hand side.
  • Address all merge conflicts and resolve appropriately
  • Pat yourself on the back for a job well done! Much love to your accomplishment!

@bms63
Copy link
Collaborator

bms63 commented Feb 4, 2025

Something to look at tomorrow @pharmaverse/admiral

@bms63 bms63 changed the title Define relationship Addresses reverse dep check for get_joined_sub_data(...) using left_join(..., relationship = "many-to-many" ) Feb 6, 2025
@bms63 bms63 merged commit ec6209d into pharmaverse:main Feb 6, 2025
18 of 19 checks passed
@bms63
Copy link
Collaborator

bms63 commented Feb 6, 2025

@krlmlr many thanks for putting this patch in for us!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants