Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

378-add-suffix-Query-for-all-queries-3 #417

Conversation

dionisiydk
Copy link
Collaborator

#378:

  • all queries are renamed to have suffix Query
  • all queriy tests are rename accordingly

Changes are done with following script:

toRename := ClyQuery allSubclasses reject: [ :each | each name includesSubstring: 'Query' ].

toRename do: [ :each | | c |
	c := SycRenameClassCommand new targetClass: each; newName: (each name, 'Query') asSymbol.
	c execute	 ].

testsToRename := toRename collect: [ :each | (each name withoutSuffix: 'Query'), 'Tests' ] thenSelect: [ :each | (self environment at: each asSymbol ifAbsent: [ nil ]) notNil ].

testsToRename do: [ :each | | c |
	c := SycRenameClassCommand new targetClass: each asClass; newName: ((each withoutSuffix: 'Tests'), 'QueryTest') asSymbol.
	c execute	 ].

#407:

  • all tests are renamed to have singular suffix Test instead of Tests

Changes are done with following script:

allTests := TestCase allSubclasses select: [ :each | each package name beginsWith: 'Calypso' ].

toRename := allTests select: [ :each | each name endsWith: 'Tests' ].
"toRename collect: [ :each | each name allButLast ]."

toRename do: [ :each | | c |
	c := SycRenameClassCommand new targetClass: each; newName: (each name allButLast) asSymbol.
	c execute	 ].

- all queries are renamed to have suffix Query
- all queriy tests are rename accordingly

Changes are done with following script:
```Smalltalk
toRename := ClyQuery allSubclasses reject: [ :each | each name includesSubstring: 'Query' ].

toRename do: [ :each | | c |
	c := SycRenameClassCommand new targetClass: each; newName: (each name, 'Query') asSymbol.
	c execute	 ].

testsToRename := toRename collect: [ :each | (each name withoutSuffix: 'Query'), 'Tests' ] thenSelect: [ :each | (self environment at: each asSymbol ifAbsent: [ nil ]) notNil ].

testsToRename do: [ :each | | c |
	c := SycRenameClassCommand new targetClass: each asClass; newName: ((each withoutSuffix: 'Tests'), 'QueryTest') asSymbol.
	c execute	 ].
```

pharo-ide#407:
- all tests are renamed to have singular suffix Test instead of Tests

Changes are done with following script:
```Smalltalk
allTests := TestCase allSubclasses select: [ :each | each package name beginsWith: 'Calypso' ].

toRename := allTests select: [ :each | each name endsWith: 'Tests' ].
"toRename collect: [ :each | each name allButLast ]."

toRename do: [ :each | | c |
	c := SycRenameClassCommand new targetClass: each; newName: (each name allButLast) asSymbol.
	c execute	 ].
```
@dionisiydk
Copy link
Collaborator Author

THis is annoying. I was sure Iceberg 0.5.3 was already integrated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant