Add suffix Query for all queries #420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
dionisiydk
commented
Jan 12, 2019
dionisiydk
commented
- all queries are renamed to have suffix Query
- all queriy tests are rename accordingly
- all tests are renamed to have singular suffix Test instead of Tests
- all queries are renamed to have suffix Query - all queriy tests are rename accordingly Changes are done with following script: ```Smalltalk toRename := ClyQuery allSubclasses reject: [ :each | each name includesSubstring: 'Query' ]. toRename do: [ :each | | c | c := SycRenameClassCommand new targetClass: each; newName: (each name, 'Query') asSymbol. c execute ]. testsToRename := toRename collect: [ :each | (each name withoutSuffix: 'Query'), 'Tests' ] thenSelect: [ :each | (self environment at: each asSymbol ifAbsent: [ nil ]) notNil ]. testsToRename do: [ :each | | c | c := SycRenameClassCommand new targetClass: each asClass; newName: ((each withoutSuffix: 'Tests'), 'QueryTest') asSymbol. c execute ]. ``` #407: - all tests are renamed to have singular suffix Test instead of Tests Changes are done with following script: ```Smalltalk allTests := TestCase allSubclasses select: [ :each | each package name beginsWith: 'Calypso' ]. toRename := allTests select: [ :each | each name endsWith: 'Tests' ]. "toRename collect: [ :each | each name allButLast ]." toRename do: [ :each | | c | c := SycRenameClassCommand new targetClass: each; newName: (each name allButLast) asSymbol. c execute ]. ```
…queries-3 378-add-suffix-Query-for-all-queries-3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.