Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unspill and new translations using static type prediction #824

Merged
merged 31 commits into from
Jul 4, 2024

Conversation

guillep
Copy link
Member

@guillep guillep commented Jun 27, 2024

This PR adds support to unspill already spilled elements.
This allows a simple automatic translation of static type predictions.

  • Add VM support to separate static type predictions
  • Add VM support for druid conditional compilation
  • Add VM support to specify stageable expressions
  • New translations for DruidJIT and DruidStaticTypePredictionJIT

Fix some bugs in the process:

  • Fix ARMv8 assertion on code patching
  • Fix type annotations in genPushMaybeContextReceiverVariable:
  • Remove mappings to primitiveStartProfiling
  • Refactor generation of calling convention to have more control over the abstract stack

@guillep guillep requested a review from PalumboN June 27, 2024 12:46
Copy link
Collaborator

@PalumboN PalumboN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Niceeee! 🤩 I left some comments with questions

smalltalksrc/VMMaker/StackInterpreter.class.st Outdated Show resolved Hide resolved
smalltalksrc/VMMaker/StackToRegisterMappingCogit.class.st Outdated Show resolved Hide resolved
smalltalksrc/VMMaker/StackToRegisterMappingCogit.class.st Outdated Show resolved Hide resolved
smalltalksrc/VMMaker/SimpleDruidJIT.class.st Show resolved Hide resolved
Comment on lines -3741 to +3853
^ CompletePrimitive
^ 0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why before it was a complete primitive and now not? 🤔

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question

smalltalksrc/VMMaker/DruidJIT.class.st Show resolved Hide resolved
smalltalksrc/VMMaker/DruidJIT.class.st Show resolved Hide resolved
@guillep
Copy link
Member Author

guillep commented Jul 3, 2024

imagen

Unit Tests are green

@guillep guillep merged commit f331bc2 into pharo-project:druid Jul 4, 2024
1 of 2 checks passed
@guillep guillep deleted the unspill branch July 4, 2024 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants