-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add unspill and new translations using static type prediction #824
Conversation
…r manipulation Add unspill operation
Fix register allocation for gen_StoreAndPopRemoteTempLongBytecode
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Niceeee! 🤩 I left some comments with questions
smalltalksrc/VMMakerCompatibilityForPharo6/PharoVMMaker.class.st
Outdated
Show resolved
Hide resolved
^ CompletePrimitive | ||
^ 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why before it was a complete primitive and now not? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question
This PR adds support to unspill already spilled elements.
This allows a simple automatic translation of static type predictions.
Fix some bugs in the process:
genPushMaybeContextReceiverVariable:
primitiveStartProfiling