Merge pull request #117 from jecisc/116-Clean-icon-management

116-Clean-icon-management
pharo-spec · Nov 7, 2018 · d8ce2e2 · d8ce2e2
2 parents 9b3dd94 + f24e4f2
commit d8ce2e2
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 2 deletions.
diff --git a/src/Spec-Core/ComposablePresenter.class.st b/src/Spec-Core/ComposablePresenter.class.st
@@ -128,6 +128,11 @@ ComposablePresenter class >> defaultSpec [
 	^ self subclassResponsibility
 ]
 
+{ #category : #accessing }
+ComposablePresenter class >> iconNamed: aSymbol [
+	^ Smalltalk ui icons iconNamed: aSymbol
+]
+
 { #category : #defaults }
 ComposablePresenter class >> inputTextHeight [
 
@@ -548,11 +553,15 @@ ComposablePresenter >> hide [
 
 { #category : #icon }
 ComposablePresenter >> icon: aSymbol [
-	"Return the icon associated with the argument."
-	self flag: #remove.
+	self deprecated: 'Use #iconNamed: instead' transformWith: '`@receiver icon: `@statements' -> '`@receiver iconNamed: `@statements'.
 	^ self iconNamed: aSymbol
 ]
 
+{ #category : #accessing }
+ComposablePresenter >> iconNamed: aSymbol [
+	^ self class iconNamed: aSymbol
+]
+
 { #category : #api }
 ComposablePresenter >> initialExtent [
 

diff --git a/src/Spec-Core/ManifestSpecCore.class.st b/src/Spec-Core/ManifestSpecCore.class.st
@@ -37,6 +37,11 @@ ManifestSpecCore class >> ruleLongMethodsRuleV1FalsePositive [
 	^ #(#(#(#RGMethodDefinition #(#AbstractWidgetPresenter #initialize #false)) #'2016-07-01T15:56:13.356024+02:00') #(#(#RGMethodDefinition #(#ComposablePresenter #initialize #false)) #'2016-07-01T15:56:13.355982+02:00') )
 ]
 
+{ #category : #'code-critics' }
+ManifestSpecCore class >> ruleRBEquivalentSuperclassMethodsRuleV1FalsePositive [
+	^ #(#(#(#RGMethodDefinition #(#'ComposablePresenter class' #iconNamed: #true)) #'2018-11-07T10:48:10.451257+01:00') )
+]
+
 { #category : #'code-critics' }
 ManifestSpecCore class >> ruleRBOverridesDeprecatedMethodRuleV1FalsePositive [
 	^ #(#(#(#RGMethodDefinition #(#MenuItemPresenter #name #false)) #'2016-07-01T15:56:13.378417+02:00') )