Skip to content

Commit

Permalink
fix: test case names
Browse files Browse the repository at this point in the history
  • Loading branch information
rohan-chaturvedi committed May 28, 2023
1 parent 4eb12ee commit 28fddbd
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion tests/test_decrypt.py
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ def test_phase_decrypt_returns_correct_plaintext(phase_instance, monkeypatch):
assert plaintext == data


def test_phase_decrypt_rejects_promise_with_incorrect_app_secret(monkeypatch):
def test_phase_decrypt_fails_with_incorrect_app_secret(monkeypatch):
phase = Phase(APP_ID, APP_SECRET_INVALID)

monkeypatch.setattr("src.phase.fetch_app_key", mock_fetch_app_key)
Expand Down
4 changes: 2 additions & 2 deletions tests/test_init.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,13 @@ def phase_instance():
return Phase(APP_ID_INVALID, APP_SECRET_INVALID)


def test_invalid_app_id(phase_instance):
def test_init_fails_with_invalid_app_id(phase_instance):
invalid_app_id = "phApp:version:cd2d579490fd794f1640590220de86a3676fa7979d419056bc631741b320b701"
with pytest.raises(ValueError, match="Invalid Phase APP_ID"):
Phase(invalid_app_id, APP_SECRET_INVALID)


def test_invalid_app_secret(phase_instance):
def test_test_init_fails_with_invalid_app_secret(phase_instance):
invalid_app_secret = "pss:v1:00000000000000000000000000000000:00000000000000000000000000000000:00000000000000000000000000000000"
with pytest.raises(ValueError, match="Invalid Phase APP_SECRET"):
Phase(APP_ID_INVALID, invalid_app_secret)

0 comments on commit 28fddbd

Please sign in to comment.