Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AbstractStorageModule::getFile - method is final #105

Closed
ihudedi opened this issue Mar 12, 2020 · 7 comments
Closed

AbstractStorageModule::getFile - method is final #105

ihudedi opened this issue Mar 12, 2020 · 7 comments
Assignees
Labels

Comments

@ihudedi
Copy link

ihudedi commented Mar 12, 2020

Hi Philip,
The getFile method in AbstractStorageModule class is final now.In older versions I think until 4.5.0 It wasn't final and we could override this method.
We would like to override this method to add our functionality.
Could you please remove the final keyword from this method.

Thanks,
Itay

phax added a commit that referenced this issue Mar 12, 2020
@phax phax self-assigned this Mar 12, 2020
@phax phax added the bug label Mar 12, 2020
@phax
Copy link
Owner

phax commented Mar 12, 2020

Hi. Sorry for the inconvenience. Part of 4.5.5 release. I made myself a note to avoid doing this again ;-)

@phax phax closed this as completed Mar 12, 2020
@ihudedi
Copy link
Author

ihudedi commented Mar 12, 2020

When 4.5.5 will be released?

@ihudedi
Copy link
Author

ihudedi commented Mar 12, 2020

We need this version soon.I can't use snapshot version.
Thanks,
Itay

@phax
Copy link
Owner

phax commented Mar 12, 2020

I don't know. Are any of the changes after 4.5.0 criticial for you?

@ihudedi
Copy link
Author

ihudedi commented Mar 12, 2020

Yes I need the fix for the bcMail.

@phax
Copy link
Owner

phax commented Mar 12, 2020

Ok building right now. In approx. half an hours it is on Maven Central

@ihudedi
Copy link
Author

ihudedi commented Mar 12, 2020

10x a lot:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants