Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sdist contains uncommited files #181

Open
sverhoeven opened this issue Aug 14, 2023 · 3 comments
Open

sdist contains uncommited files #181

sverhoeven opened this issue Aug 14, 2023 · 3 comments

Comments

@sverhoeven
Copy link
Collaborator

sverhoeven commented Aug 14, 2023

Running hatch build creates a dist/springtime-0.1.0.tar.gz file. If your local cloned repo is not clean then the tarball will contain uncommitted files.

For example I had copy of /tmp/data that was included in the tarball. (this was from before #178).

We should change the hatch config so only files under version control are included. Or have a CI workflow to publish to PyPI.

@sverhoeven sverhoeven mentioned this issue Aug 14, 2023
@Peter9192
Copy link
Collaborator

Thanks for spotting and pointing that out! Would it be enough if we only include the source dir, e.g. using the packages option?

@Peter9192
Copy link
Collaborator

I suppose we need to update the license section of the metadata in pyproject.toml

@Peter9192
Copy link
Collaborator

If we tinker with this, we might also think about the inclusion of (example) recipes in the distribution. See #164 (comment)

@Peter9192 Peter9192 mentioned this issue Feb 2, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants