Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make directories customizable #178

Merged
merged 5 commits into from
Jul 14, 2023
Merged

Make directories customizable #178

merged 5 commits into from
Jul 14, 2023

Conversation

sverhoeven
Copy link
Collaborator

Fixes #44

Peter9192
Peter9192 approved these changes Jul 14, 2023
View reviewed changes
Copy link
Collaborator

@Peter9192 Peter9192 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice pair programming session :-)
Works on my end as well, tests now green and conflicts fixed.

Let's get this in, further improvements (e.g. also accept environment vars so we can set those in dockerfile) can be added in follow-up PRs

@Peter9192 Peter9192 marked this pull request as ready for review July 14, 2023 14:43
@Peter9192 Peter9192 merged commit e667649 into main Jul 14, 2023
@Peter9192 Peter9192 deleted the configurable-dirs branch July 14, 2023 14:43
@sverhoeven sverhoeven mentioned this pull request Aug 14, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Peter9192 Peter9192 Peter9192 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support configuration in multiple ways
2 participants
@sverhoeven @Peter9192