-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for exporting to GCloud Functions / Firebase Functions #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JasperH8g
requested changes
Nov 1, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, as always 😊
packages/server/src/commands/export/gcloud-functions/generateLibFile.ts
Outdated
Show resolved
Hide resolved
packages/server/src/commands/export/gcloud-functions/generateServiceIndexFile.ts
Outdated
Show resolved
Hide resolved
Implement Vercel Export
JasperH8g
approved these changes
Nov 4, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💪
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change you could only create an export for NodeJS. This PR makes makes the export compatible with GCloud Functions / Firebase Functions. Because we now have 2 "flavors" for the export, we added a new flag "--flavor" to the export command.
To create a NodeJS compatible export:
To create a GCloud Functions / Firebase Functions compatible export:
These will output an "export" directory in your project directory. In it, you will find a directory for each service you've defined in your
phero.ts
file.To run the NodeJS exported services:
To deploy a services to Firebase/GCloud, you should run:
For every service we will export a different bundle. We will of course document all this in docs after release.