You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
RequiredOption.ts looks like it duplicates PickRequired.ts. We had a long discussion about PickRequired.ts (and its name) in https://github.com/phetsims/phet-io/issues/1843, and decided on PickRequired.ts and PickOptional.ts.
Recommended to delete RequiredOption.ts.
The text was updated successfully, but these errors were encountered:
We discussed this in 3/3/2022 dev meeting, and they are in fact different. I updated the doc in RequiredOption.ts to clarify.
But the name is still misleading. It returns the type of an option, and it doesn't even need to be a required option (as demonstrated by the example in the doc.) Should it be renamed to something like TypeOfOption or OptionType?
RequiredOption.ts looks like it duplicates PickRequired.ts. We had a long discussion about PickRequired.ts (and its name) in https://github.com/phetsims/phet-io/issues/1843, and decided on PickRequired.ts and PickOptional.ts.
Recommended to delete RequiredOption.ts.
The text was updated successfully, but these errors were encountered: