Link hints: false positives and scrollable divs #2069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes philc#425. Conflicts: content_scripts/scroller.coffee
We recognise elements with a class names containing the text "button" as clickable. However, often they're not, they're just wrapping a clickable thing, like a real button. Here, we filter out such false positives. This has two effects: - It eliminates quite a number of real false pasitives in practice. - With fewer hints close together, fewer hint markers are obscured by the hints from (non-clickable) wrappers. This reduces the need for rotating the hint stacking order, e.g philc#1252.
Testing the `scrollHeight` is cheaper than testing scrollability. There are a lot of non-scrollabile divs, so it makes sense to use this cheaper test as a filter.
|
hi, could you please comment on how to use it. I cant find any documentation on this and it's not clear from the code. thanks |
|
There's nothing that you (the user does). The text |
|
thank you. is it possible to apply without hint filtering? |
|
The hint is still there with alphabet hints, you just don't have the text "Scroll" next to it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on #2048 (global link hints) adding two new features:
Filter out false positives
We mark any element with a class name containing the text
buttonas clickable. Many of these are wrappers around real clickables. E.g....Here, we treat the outer
spanas a false positive (because a close descendent is a real clickable). This has two effects:Make scrollable divs selectable
Here's an example (using filtered hints):
Fixes #425.
Fixes #2056.
(I intend to merge this directly; this PR is just for visibility.)