now showing blue/green status indicator when there are no jobs but we filtered out successful jobs #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since this extension is pretty slow and it tends to freeze the gnome-shell when there are many jobs, some users (like me) needs to filter-out successful-jobs to get an usable interface.
In these cases, when there are no jobs the extensions shows an error while the correct indication should be "everything is building correctly".
I changed this behavior by checking for the show_successful_jobs when no jobs are found.
The message "no jobs found" is still being shown but as warning instead as an error so that the user may still check for its filters if the result does not match with the expected.