fix: dependency updates lambda (#3965)

## Updates - updating all npm packages - add dependabot version ignore for updates not possible - ockotkit rest minor update breaks the app auth #3966 - fix nx configuration ## Tests Fresh deployment with multi-runner example
philips-labs · Jul 5, 2024 · a6df2b6 · a6df2b6
1 parent 77b75ec
commit a6df2b6
Show file tree

Hide file tree

Showing 11 changed files with 1,609 additions and 1,738 deletions.
diff --git a/.github/dependabot.yml b/.github/dependabot.yml
@@ -27,6 +27,18 @@ updates:
       octokit:
         patterns:
           - "@octokit/*"
+    ignore:
+      - dependency-name: "aws-sdk*"
+        update-types: ["version-update:semver-major"]
+      - dependency-name: "aws-lambda-powertools/*"
+        update-types: ["version-update:semver-major"]
+      - dependency-name: "@middy/core"
+        update-types: ["version-update:semver-major"]
+      - dependency-name: "@@octokit/*"
+        update-types: ["version-update:semver-major"]
+      - dependency-name: "@@octokit/rest"
+      - dependency-name: "eslint"
+        update-types: ["version-update:semver-major"]
     commit-message:
       prefix: "fix(lambda)"
       prefix-development: "chore(lambda)"
diff --git a/lambdas/functions/ami-housekeeper/package.json b/lambdas/functions/ami-housekeeper/package.json
@@ -26,12 +26,12 @@
     "aws-sdk-client-mock": "^3.0.0",
     "aws-sdk-client-mock-jest": "^3.0.0",
     "eslint": "^8.56.0",
-    "eslint-plugin-prettier": "5.1.2",
+    "eslint-plugin-prettier": "5.1.3",
     "jest": "^29.5",
     "jest-mock": "^29.5.0",
     "jest-mock-extended": "^3.0.6",
     "nock": "^13.4.0",
-    "prettier": "3.2.5",
+    "prettier": "3.3.2",
     "ts-jest": "^29.1.0",
     "ts-node": "^10.9.1",
     "ts-node-dev": "^2.0.0"
@@ -46,6 +46,15 @@
     "typescript": "^5.4.5"
   },
   "nx": {
-    "includedScripts": ["build","dist","format","format-check","start","watch","all"]
+    "includedScripts": [
+      "build",
+      "dist",
+      "format",
+      "format-check",
+      "lint",
+      "start",
+      "watch",
+      "all"
+    ]
   }
 }
diff --git a/lambdas/functions/control-plane/package.json b/lambdas/functions/control-plane/package.json
@@ -8,7 +8,7 @@
     "test": "NODE_ENV=test nx test",
     "test:watch": "NODE_ENV=test nx test --watch",
     "lint": "yarn eslint src",
-    "watch": "ts-node-dev --respawn --exit-child src/local-ssm-housekeeper.ts",
+    "watch": "ts-node-dev --respawn --exit-child --files src/local.ts",
     "build": "ncc build src/lambda.ts -o dist",
     "dist": "yarn build && cd dist && zip ../runners.zip index.js",
     "format": "prettier --write \"**/*.ts\"",
@@ -26,13 +26,13 @@
     "aws-sdk-client-mock": "^3.0.0",
     "aws-sdk-client-mock-jest": "^3.0.0",
     "eslint": "^8.56.0",
-    "eslint-plugin-prettier": "5.1.2",
+    "eslint-plugin-prettier": "5.1.3",
     "jest": "^29.5",
     "jest-mock": "^29.5.0",
     "jest-mock-extended": "^3.0.6",
     "moment-timezone": "^0.5.45",
     "nock": "^13.4.0",
-    "prettier": "3.2.5",
+    "prettier": "3.3.2",
     "ts-jest": "^29.1.0",
     "ts-node": "^10.9.1",
     "ts-node-dev": "^2.0.0"
@@ -43,14 +43,23 @@
     "@middy/core": "^4.7.0",
     "@octokit/auth-app": "6.0.3",
     "@octokit/rest": "20.0.2",
-    "@octokit/types": "^12.5.0",
+    "@octokit/types": "^13.5.0",
     "@terraform-aws-github-runner/aws-powertools-util": "*",
     "@terraform-aws-github-runner/aws-ssm-util": "*",
     "axios": "^1.6.8",
     "cron-parser": "^4.8.1",
     "typescript": "^5.4.5"
   },
   "nx": {
-    "includedScripts": ["build","dist","format","format-check","start","watch","all"]
+    "includedScripts": [
+      "build",
+      "dist",
+      "format",
+      "format-check",
+      "lint",
+      "start",
+      "watch",
+      "all"
+    ]
   }
 }
diff --git a/lambdas/functions/gh-agent-syncer/package.json b/lambdas/functions/gh-agent-syncer/package.json
@@ -28,10 +28,10 @@
     "aws-sdk-client-mock": "^3.0.0",
     "aws-sdk-client-mock-jest": "^3.0.0",
     "eslint": "^8.56.0",
-    "eslint-plugin-prettier": "5.1.2",
+    "eslint-plugin-prettier": "5.1.3",
     "jest": "^29.5",
     "jest-mock": "^29.5.0",
-    "prettier": "3.2.5",
+    "prettier": "3.3.2",
     "ts-jest": "^29.1.0",
     "ts-node-dev": "^2.0.0",
     "typescript": "^5.4.5"
@@ -45,6 +45,15 @@
     "axios": "^1.6.8"
   },
   "nx": {
-    "includedScripts": ["build","dist","format","format-check","start","watch","all"]
+    "includedScripts": [
+      "build",
+      "dist",
+      "format",
+      "format-check",
+      "lint",
+      "start",
+      "watch",
+      "all"
+    ]
   }
 }
diff --git a/lambdas/functions/termination-watcher/package.json b/lambdas/functions/termination-watcher/package.json
@@ -24,12 +24,12 @@
     "aws-sdk-client-mock": "^3.0.0",
     "aws-sdk-client-mock-jest": "^3.0.0",
     "eslint": "^8.56.0",
-    "eslint-plugin-prettier": "5.1.2",
+    "eslint-plugin-prettier": "5.1.3",
     "jest": "^29.5",
     "jest-mock": "^29.5.0",
     "jest-mock-extended": "^3.0.6",
     "nock": "^13.4.0",
-    "prettier": "3.2.5",
+    "prettier": "3.3.2",
     "ts-jest": "^29.1.0",
     "ts-node": "^10.9.1",
     "ts-node-dev": "^2.0.0"
@@ -42,6 +42,15 @@
     "typescript": "^5.4.5"
   },
   "nx": {
-    "includedScripts": ["build","dist","format","format-check","start","watch","all"]
+    "includedScripts": [
+      "build",
+      "dist",
+      "format",
+      "format-check",
+      "lint",
+      "start",
+      "watch",
+      "all"
+    ]
   }
 }
diff --git a/lambdas/functions/webhook/package.json b/lambdas/functions/webhook/package.json
@@ -27,12 +27,12 @@
     "@vercel/ncc": "0.38.1",
     "body-parser": "^1.20.2",
     "eslint": "^8.56.0",
-    "eslint-plugin-prettier": "5.1.2",
+    "eslint-plugin-prettier": "5.1.3",
     "express": "^4.19.2",
     "jest": "^29.5",
     "jest-mock": "^29.5.0",
     "nock": "^13.4.0",
-    "prettier": "3.2.5",
+    "prettier": "3.3.2",
     "ts-jest": "^29.1.0",
     "ts-node-dev": "^2.0.0",
     "typescript": "^5.4.5"
@@ -41,13 +41,22 @@
     "@aws-sdk/client-sqs": "^3.600.0",
     "@middy/core": "^4.7.0",
     "@octokit/rest": "^20.0.1",
-    "@octokit/types": "^12.5.0",
+    "@octokit/types": "^13.5.0",
     "@octokit/webhooks": "^12.1.2",
     "@terraform-aws-github-runner/aws-powertools-util": "*",
     "@terraform-aws-github-runner/aws-ssm-util": "*",
     "aws-lambda": "^1.0.7"
   },
   "nx": {
-    "includedScripts": ["build","dist","format","format-check","start","watch","all"]
+    "includedScripts": [
+      "build",
+      "dist",
+      "format",
+      "format-check",
+      "lint",
+      "start",
+      "watch",
+      "all"
+    ]
   }
 }
diff --git a/lambdas/functions/webhook/src/sqs/index.test.ts b/lambdas/functions/webhook/src/sqs/index.test.ts
@@ -112,6 +112,7 @@ describe('Test sending message to SQS.', () => {
     expect(SQS).not.toHaveBeenCalled();
   });
 
+  // eslint-disable-next-line max-len
   it('Does not send webhook events to workflow job event copy queue when job queue is set to empty string', async () => {
     // Arrange
     process.env.SQS_WORKFLOW_JOB_QUEUE = '';

diff --git a/lambdas/libs/aws-powertools-util/package.json b/lambdas/libs/aws-powertools-util/package.json
@@ -25,12 +25,12 @@
     "@vercel/ncc": "0.38.1",
     "body-parser": "^1.20.2",
     "eslint": "^8.56.0",
-    "eslint-plugin-prettier": "5.1.2",
+    "eslint-plugin-prettier": "5.1.3",
     "express": "^4.19.2",
     "jest": "^29.5",
     "jest-mock": "^29.5.0",
     "nock": "^13.4.0",
-    "prettier": "3.2.5",
+    "prettier": "3.3.2",
     "ts-jest": "^29.1.0",
     "ts-node-dev": "^2.0.0",
     "typescript": "^5.4.5"
@@ -43,10 +43,9 @@
   },
   "nx": {
     "includedScripts": [
-      "build",
-      "dist",
       "format",
       "format-check",
+      "lint",
       "start",
       "watch",
       "all"

diff --git a/lambdas/libs/aws-ssm-util/package.json b/lambdas/libs/aws-ssm-util/package.json
@@ -25,12 +25,12 @@
     "@vercel/ncc": "0.38.1",
     "body-parser": "^1.20.2",
     "eslint": "^8.56.0",
-    "eslint-plugin-prettier": "5.1.2",
+    "eslint-plugin-prettier": "5.1.3",
     "express": "^4.19.2",
     "jest": "^29.5",
     "jest-mock": "^29.5.0",
     "nock": "^13.4.0",
-    "prettier": "3.2.5",
+    "prettier": "3.3.2",
     "ts-jest": "^29.1.0",
     "ts-node-dev": "^2.0.0",
     "typescript": "^5.4.5"
@@ -41,6 +41,13 @@
     "@terraform-aws-github-runner/aws-powertools-util": "*"
   },
   "nx": {
-    "includedScripts": ["build","dist","format","format-check","start","watch","all"]
+    "includedScripts": [
+      "format",
+      "format-check",
+      "lint",
+      "start",
+      "watch",
+      "all"
+    ]
   }
 }
diff --git a/lambdas/package.json b/lambdas/package.json
@@ -18,17 +18,17 @@
     "affected:test": "nx affected:test --parallel"
   },
   "resolutions": {
-    "@octokit/types": "^12.0.0"
+    "@octokit/types": "^13.0.0"
   },
   "devDependencies": {
-    "@nx/eslint": "18.3.4",
-    "@nx/jest": "18.3.4",
-    "@nx/js": "^18.0.4",
-    "@swc-node/register": "~1.8.0",
-    "@swc/core": "~1.3.85",
+    "@nx/eslint": "19.4.0",
+    "@nx/jest": "19.4.0",
+    "@nx/js": "^19.4.0",
+    "@swc-node/register": "~1.10.0",
+    "@swc/core": "~1.6.7",
     "@swc/helpers": "~0.5.2",
     "jest": "^29.4.1",
-    "nx": "18.0.4",
+    "nx": "19.4.0",
     "prettier": "^3.2.5"
   }
 }