Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move UDEVADM and SHUTDOWN definitions to runtime constants #2564 #3

Conversation

FroggyFlox
Copy link

@phillxnet, this is another pull-request that compiles changes we discussed, hoping it'll help.

This PR moves the definitions of UDEVADM and SHUTDOWN from our Django settings to run time in the already existing system.constants.py.

Note that in Leap 15.4, we have:

rockdev:/opt/rockstor # which udevadm
/sbin/udevadm

But this is just a symlink to /usr/bin/udevadm:

rockdev:/opt/rockstor # ls -lah /sbin/udevadm
lrwxrwxrwx 1 root root 16 Apr 28 11:09 /sbin/udevadm -> /usr/bin/udevadm

/usr/bin/udevadm is also the correct path in Tumbleweed, so using this path covers both Leap and Tumbleweed.

To test:

  • the branch builds successfully
  • rockstor-bootstrap starts successfully
  • I can access the Rockstor first login UI.

Hope this helps,

Verified

This commit was signed with the committer’s verified signature.
flavorjones Mike Dalessio
@phillxnet
Copy link
Owner

@FroggyFlox Thanks for this - much appreciated. I may loose commit attribution as a squash my current working branch but this is a great help so popping in as I go. We should hopefully have a mostly working base to push to testing and move to working from there via issue-pr sets.

@phillxnet phillxnet merged commit 3635546 into phillxnet:2564_Update_pyproject.toml_and_poetry.lock_for_python_3.6 Jun 5, 2023
@FroggyFlox FroggyFlox deleted the 2564_Move_BIN_def_from_build_to_runtime branch June 5, 2023 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants