Don't run prettier by eslint if run by prettier

.eslintrc.json

@@ -4,15 +4,13 @@
     "es6": true,
     "node": true
   },
-  "extends": ["airbnb-base", "plugin:prettier/recommended"],
+  "extends": ["airbnb-base", "prettier"],
   "globals": {
     "Atomics": "readonly",
     "SharedArrayBuffer": "readonly"
   },
   "parserOptions": {
     "ecmaVersion": 2018
   },
-  "rules": {
-    "prettier/prettier": "error"
-  }
+  "rules": {}
 }

lib/add-prettier-config.js

@@ -13,24 +13,27 @@ const {
   // fileOptions,
 } = require('./prettier-questions')
 
-const addPrettierToExtends = eslintObj => {
+const addPrettierToExtends = (eslintObj, prettierExtensionStr) => {
   return Array.isArray(eslintObj.extends)
-    ? [...eslintObj.extends, 'plugin:prettier/recommended']
+    ? [...eslintObj.extends, prettierExtensionStr]
     : eslintObj.extends
-    ? [eslintObj.extends, 'plugin:prettier/recommended']
-    : 'plugin:prettier/recommended'
+    ? [eslintObj.extends, prettierExtensionStr]
+    : prettierExtensionStr
 }
 
 const addPrettierToRules = (prettierObj, eslintObj) => ({
   ...eslintObj.rules,
   'prettier/prettier': prettierObj ? ['error', prettierObj] : 'error',
 })
 
-const extendESLintConfig = (eslintObj, prettierObj) => ({
-  ...eslintObj,
-  extends: addPrettierToExtends(eslintObj),
-  rules: addPrettierToRules(prettierObj, eslintObj),
-})
+const extendESLintConfig = (eslintObj, prettierObj) =>
+  prettierObj
+    ? {
+        ...eslintObj,
+        extends: addPrettierToExtends(eslintObj, 'plugin:prettier/recommended'),
+        rules: addPrettierToRules(prettierObj, eslintObj),
+      }
+    : { ...eslintObj, extends: addPrettierToExtends(eslintObj, 'prettier') }
 
 const prettierQuestions = () =>
   inquirer

lib/index.test.js

@@ -99,12 +99,38 @@ test('extendESLintConfig has already rules', t => {
   t.deepEqual(eslintObj, expected)
 })
 
-test('extendESLintConfig no prettier', t => {
+test('extendESLintConfig turn off eslint formating rules', t => {
   const eslintObj = extendESLintConfig({})
 
   const expected = {
-    extends: 'plugin:prettier/recommended',
-    rules: { 'prettier/prettier': 'error' },
+    extends: 'prettier',
+  }
+
+  t.deepEqual(eslintObj, expected)
+})
+
+test('extendESLintConfig turn off eslint formating rules with existing eslint rules', t => {
+  const eslintObj = extendESLintConfig({
+    rules: { 'no-underscore-dangle': 'off' },
+  })
+
+  const expected = {
+    extends: 'prettier',
+    rules: { 'no-underscore-dangle': 'off' },
+  }
+
+  t.deepEqual(eslintObj, expected)
+})
+
+test('extendESLintConfig turn off eslint formating rules with existing eslint rules and extensions', t => {
+  const eslintObj = extendESLintConfig({
+    extends: ['other-extention'],
+    rules: { 'no-underscore-dangle': 'off' },
+  })
+
+  const expected = {
+    extends: ['other-extention', 'prettier'],
+    rules: { 'no-underscore-dangle': 'off' },
   }
 
   t.deepEqual(eslintObj, expected)

package.json

@@ -31,7 +31,7 @@
   },
   "devDependencies": {
     "ava": "^1.2.1",
-    "eslint": "^5.15.1",
+    "eslint": "^5.15.3",
     "eslint-config-airbnb-base": "^13.1.0",
     "eslint-config-prettier": "^4.1.0",
     "eslint-plugin-import": "^2.16.0",