This repository was archived by the owner on Nov 17, 2021. It is now read-only.
Fixes Issue #93 - File upload not working #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@phiz71 Build failed because sonarqube could not be reached. Any chance you can take a look at this? |
|
Thanks @petebuletza for this PR and thanks for the unit-test. |
|
No problem. @elx-britt and I have been working a lot with this for a project and have some other improvements that we've made on a fork that we're going to start to integrate. Thanks for merging. |
|
@phiz71 Can we get a patch release of this merged code published? It will help unblock my current issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generated Verticle now creates a
Fileobject from themessage.body().getString("file").Adds a test for this case.