Fix issue with new elements in stream DOM test #2677
Merged
+17
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This resolves an issue for testing streams. New items didn't get assigned the data-phx-stream and thus subsequent stream resets didn't reset the list as the previously added items couldn't be matched for the data-phx-stream.
danschultzer
force-pushed
the
fix-stream-dom-test-issue
branch
from
41220d7 to
e2d3152
Compare
|
@chrismccord, @josevalim Could we have this one merged? I can confirm that it fixes the problem (and the follow up) I described in #2629 (comment). |
|
❤️❤️❤️🐥🔥 |
SteffenDE
pushed a commit
to SteffenDE/phoenix_live_view
that referenced
this pull request
Dec 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I encountered this issue testing pagination with stream resets. Going to next page the first time worked, but subsequent stream resets failed (though it worked just fine in the browser).
This is due to the container id check. New items don't have any parent because the id would be unique. It just skips the element entirely, thus not setting the
data-phx-streamvalue. It works the first time because the DOM already has the first list with ids.The simplest fix I could think of was just to ignore if parent_id is nil (this means new unique item), but not sure I like this because what happens if you have multiple lists? Wouldn't it just update all lists? I couldn't grok how this is dealt with in JS, so I'm leaving it for now.