-
-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GPS Tag Write not setting negative #131
Comments
I've just pushed a test that verifies that all combinations of negative, zero, and positive values for GPS work properly on all platforms. See https://github.com/photostructure/exiftool-vendored.js/actions/runs/4154789945 and d9bfd9a (these tests pass on Windows using an older build, fwiw). Note that you don't want to call write twice in your example, and I expect that's your issue. This is what your code should look like: const GPSLatitude = 39.1132577;
const GPSLongitude = -84.6907715;
await exiftool.write(file, { GPSLatitude, GPSLongitude }); |
Looks like this works correctly if I change ExifTool to v12.50, but fails on 12.55. It may be in my code or in ExifTool--I need to look into it more. You can try it locally by editing this section of the package.json:
I'll get this addressed in the next day or two. Thanks for the bug report! |
I tried your approach and got the same result. I also tried to to null them first then go back and set them and it still set the GPSLongitude to positive.
I changing the optionalDependencies like you mentioned and first got the same result. Then I realized I needed to npm install in the exiftool-vendored dir in node_modules before re-running and then boom it worked!! Thanks for this and I'm happy to help any further. |
I looked at the recent git logs for exiftool and didn't see a smoking gun there. I posted a bug report to their forum--they're really responsive. |
According to the ExifTool Gurus, I need to specify the Ref explicitly to handle different filetypes. I've just made this change to the branch--if it passes on all platforms, I can ship the bugfix. |
Merged to main and released. Thanks again for the bug report! |
This maybe a dumb question given my limited knowledge of GPS data but when I try to set the Latitude and Longitude tags they get set to only positive numbers.
When I open the file it shows the GPS as 39.1132577 latitude and 84.6907715 longitude (middle of the ocean). I feel like I a missing something and its pretty simple. Everything else I've used this for works great! Thanks!
The text was updated successfully, but these errors were encountered: